fix: Fix taskbroker CI issues#640
Merged
Merged
Conversation
untitaker
force-pushed
the
fix/precommit-all-files-on-main
branch
from
fd28b1b to
a18d52f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a18d52f. Configure here.
untitaker
force-pushed
the
fix/precommit-all-files-on-main
branch
from
a18d52f to
1102b94
Compare
- Update CI workflow to run pre-commit on all files when pushing to main, while still running only on changed files for PRs - Fix isort imports in devenv/sync.py - Fix black formatting in integration tests This prevents formatting drift when commits bypass pre-commit hooks locally. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
untitaker
force-pushed
the
fix/precommit-all-files-on-main
branch
from
1102b94 to
bfd2fc3
Compare
Member
Author
|
This PR had to reformat integration tests after touching them: #639 trying to prevent that by making main run the formatter on all files. |
- gRPC server now only starts when grpc_port > 0 - Setting grpc_port=0 disables the gRPC server entirely - Update rebalancing test to disable gRPC since it's not needed The rebalancing test only verifies Kafka→SQLite deduplication during consumer rebalancing. It doesn't use workers, so the gRPC server is unnecessary and was causing flaky AddrInUse failures. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
untitaker
changed the title
george-sentry
approved these changes
May 18, 2026
Member
george-sentry
left a comment
george-sentry
left a comment
There was a problem hiding this comment.
Looks good to me if that flaky test passes a few times in a row.
fpacifici
approved these changes
May 18, 2026
enochtangg
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes several CI issues in taskbroker:
Pre-commit on all files for main - Update CI workflow to run pre-commit on all files when pushing to main branch (not just changed files), preventing formatting drift
Fix existing formatting - Fix isort/black formatting in
devenv/sync.pyand integration testsFix flaky rebalancing test - Make gRPC server optional (
grpc_port=0disables it). The rebalancing test only tests Kafka→SQLite deduplication and doesn't need gRPC, but was failing withAddrInUseerrors when trying to bind portsFixes STREAM-1004
Test plan
🤖 Generated with Claude Code